PM73235: THE METHOD _REMOVEFIRST() FROM THE OMLIST CLASS IN OXF HAS NULL CHECKS WHICH ARE PERFORMED IN THE WRONG ORDER

Rational Rhapsody Fix Pack 8.0.1
Rational Rhapsody 8.0.6

APAR status

• Closed as program error.

Error description

• In the following code from the class OMList in the OXF
  framework, the variable first is checked to see if it is equal
  to Null after having one of its methods invoked, which should
  throw a null pointer exception error if first is equal to null.
  The null check should have been performed before a method from
  the 'first' object is called to prevent this exception from
  being thrown.
  
  //## class OMList
  // Linked list container class
  template ?class Concept? class OMList : public
  OMAbstractContainer?Concept? {
  ...
  inline void _removeFirst(void) {
    //#[ operation _removeFirst()
    Item* tmp = first;   ?-- tmp is set with a value assumed not
  NULL
    first = first-?next; ?-- first is never checked for being
  equal to NULL before use
    if (first == NULL) {
      last = NULL;
    }
    if (tmp != NULL) {   ?-- tmp that is based on first is checked
  for NULL
      delete tmp;
      --count_;
    }
    //#]
  }
  

Local fix

Problem summary

• ****************************************************************
  * USERS AFFECTED:                                              *
  ****************************************************************
  * PROBLEM DESCRIPTION:                                         *
  ****************************************************************
  * RECOMMENDATION:                                              *
  ****************************************************************
  The method _removeFirst() from the OMList class in OXF has
  null checks which are performed in the wrong order
  

Problem conclusion

• Fixed in 8.0.1
  

Temporary fix

Comments

APAR Information

• APAR is sysrouted FROM one or more of the following:

• APAR is sysrouted TO one or more of the following:

Fix information

• Fixed component name

  TLOGIC RHAPSODY

• Fixed component ID

  5724V74RP

Applicable component levels

• R760 PSN

     UP